search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Social Menu: Add TripAdvisor support #7318

Open vladolaru opened 7 years ago

vladolaru commented 7 years ago

I believe it would be great if we could include TripAdvisor among the supported icons as people seem to link to the site from their travel blogs.

zinigor commented 7 years ago

@jasmussen is there a chance we can get a TripAdvisor logo into genericons?

jasmussen commented 7 years ago

I think we are switching to Social Logos for all logo work being done, see https://github.com/Automattic/social-logos — and yes, trip adviser seems a good candidate to add!

rickcurran commented 5 years ago

Hi, I'm looking to tackle a "Good first bug" and I was wondering if this one still required attention? I can see that there has been no TripAdvisor logo to Social Logos so I was thinking this might be a good place to start, perhaps adding other missing social logos in the process.

I'm new to contributing so I'm keen to get my head around the process involved so any guidance / suggestions welcome!

jeherve commented 5 years ago

We still have no TripAdvisor so this would indeed be a good place to start. You could suggest that logo in this repo: https://github.com/Automattic/social-logos/

You can look at past Pull Requests to see how things were done.

Once we have the icon in the Social Logos icon font, we'll be able to leverage it in Jetpack.

rickcurran commented 5 years ago

Hi, I've started looking into providing this and other logos to Social Logos but I'm having problems being able to run the build tools. Is this something I can get help with via the WordPress Slack? (I'm also having problems with the Jetpack dev environment too which would also be good to get some help with, actually getting full reboot crashes on my dev machine which is odd).

jeherve commented 5 years ago

I'm having problems being able to run the build tools.

Do you get any errors when running npm install or npm run build in the repo? if so, do the errors offer any indicator about what the problem could be?

Is this something I can get help with via the WordPress Slack? (I'm also having problems with the Jetpack dev environment too which would also be good to get some help with, actually getting full reboot crashes on my dev machine which is odd

Feel free to ping me on Slack any time, I'll be happy to help if I can. If I can't, we can open an issue here on this repo to get more eyes on your problem :)

rickcurran commented 5 years ago

@jeherve I just wiped and re-cloned the 'social-logos' repo just to try it from scratch. I ran npm install and it immediately froze my system and after a few minutes my computer reboots – no idea how it's causing that to happen! I've installed a few new things in the last few days such as Docker etc as part of trying to get the Jetpack dev environment up and running, so something amongst these changes is causing it. I think I'll try and clear it out and start from scratch.

jeherve commented 5 years ago

I think I'll try and clear it out and start from scratch.

Let's chat about how that goes!

rickcurran commented 5 years ago

I've added a PR in the Social Logos repo now for the TripAdvisor logo:

https://github.com/Automattic/social-logos/pull/90

Can anyone give them a bump to see if that can get merged etc? I've added this and other PRs for JSON Feed, Micro.blog and Stack Overflow family icons too, but there also seems to be a few other outstanding PRs there that haven't been reviewed / approved.