search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 799 forks source link

Subscriptions: include CPTs #760

Open jeherve opened 10 years ago

jeherve commented 10 years ago

Currently, the subscriptions module will only notify subscribers when a new post is made on the blog.

Since WP 3.0, CPTs (custom-post-types) have started playing an increasingly dominant role in many blogs. Therefore, I believe it would be a great addition to Jetpack to add the option for blog admins to select which post types will be included in these updates.

Original trac ticket:

seejacobscott commented 6 years ago

requested in 754461-zen

richardmtl commented 6 years ago

Requested in https://wordpress.org/support/topic/how-to-include-jetpack-portfolio-projects-in-jetpack-email-subscriptions/

richardmtl commented 6 years ago

921071-zen

ntpixels commented 6 years ago

938726-zen

tmmbecker commented 6 years ago

requested in https://wordpress.org/support/topic/how-to-manage-notify-me-of-follow-up-comments-by-email-for-custom-post-type/

ntpixels commented 6 years ago

1094364-zen

rvpatel commented 6 years ago

https://wordpress.org/support/topic/how-to-manage-notify-me-of-follow-up-comments-by-email-for-custom-post-type/ @erania-pinnera and @tmmbecker

Please provide a options for post type selection where you have need Notify me of follow-up comments by email

\jetpack\modules\subscriptions.php line no 616 if ( FALSE === has_filter( 'comment_form', 'show_subscription_checkbox' ) && 1 == get_option( 'stc_enabled', 1 ) && empty( $post->post_password ) && 'post' == get_post_type() ) {

There have not any filter function for change the code. Can we apply on custom post type?

jeherve commented 6 years ago

There have not any filter function for change the code. Can we apply on custom post type?

Adding a filter here or changing the code in the plugin won't help I'm afraid. We would need to add support for Custom Post Types on WordPress.com first, where the emails are generated and sent.

We will update this issue once we make progress on this.

coder-karen commented 5 years ago

Requested in 1388180-zen

pmciano commented 5 years ago

Requested in 1677630-zen

mfigrs commented 5 years ago

After 4.5 years since the original issue, it is quite disappointing that Jetpack still can't send notification on CPTs - not even a post title and link.

Is there a way to make a CPT pretend to be a regular post for Jetpack?

jeherve commented 5 years ago

Is there a way to make a CPT pretend to be a regular post for Jetpack?

I am afraid not, that is not really possible right now. Since the posts are sent from the WordPress.com servers, you can't really "trick" the posts to send out emails.

We'll post on this issue as soon as we start working on Subscriptions again and can pick this up.

andrespazsoldan commented 5 years ago

And that is? Maybe for the year 2030? :(

jeherve commented 5 years ago

And that is? Maybe for the year 2030? :(

We don't have any estimate as this is not on our roadmap right now. We'll post here when that changes.

abcxyz-m commented 5 years ago

Requested in 1905752-zen.

stale[bot] commented 4 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

tmmbecker commented 4 years ago

Still a request.

andrespazsoldan commented 4 years ago

Yes, still a request, after all these years. Would be nice to know it has been addressed : (

createscape commented 4 years ago

Hello, I would like to request this feature as well.

stale[bot] commented 4 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

BrookeDot commented 4 years ago

VIP client request in 109953-zd-wordpressvip.

sophiegyo commented 3 years ago

We had a user who was asking after this in 3535140-zen as well today.

w33zy commented 3 years ago

It is 2021 and this is still an issue.

If only there was a way we could tie this issue to something that Gutenberg needs... it would've been resolved within the hour.

Kevin-Hamilton commented 3 years ago

@jeherve who would be the best person to lobby for getting this onto the roadmap? What would be the best method for contacting that person?

jeherve commented 3 years ago

@Kevin-Hamilton You're in the right place! This is where we track and monitor bugs as well as feature requests for Jetpack.

We're not currently working on the Subscriptions feature, hence why this issue has remained opened for so long without any updates. When we do start iterating on the Subscriptions feature again, we'll look at feature requests just like this one to help us prioritize.

As my colleague mentioned above when we first discussed this feature, Custom Post Types in WordPress often rely on a custom content structure. When defining a new post type, and as you most likely know, one can choose whether they want to use post titles or not. They may also decide to rely on custom taxonomies or custom post meta instead of storing the main content in the post content area. This does make things a bit more difficult, as we would have to make assumptions that may not be correct when building the title and body of the email that needs to be sent.

In any case, until we start working on this, I can only recommend that you turn towards a different plugin to handle email subscriptions for Custom Post Types. MailPoet, for example, supports Custom Post Types. While it doesn't work exactly like Jetpack's Subscriptions feature, it may fit your needs.

w33zy commented 3 years ago

@jeherve

When defining a new post type, and as you most likely know, one can choose whether they want to use post titles or not. They may also decide to rely on custom taxonomies or custom post meta instead of storing the main content in the post content area. This does make things a bit more difficult, as we would have to make assumptions that may not be correct when building the title and body of the email that needs to be sent.

Wouldn't all of the above be remedied by filters and actions? I mean, all you guys have to do is work with the post title and post content as usual, then provide appropriate hooks to alter these pieces of info.

Hooks are what makes WordPress so powerful, and this is a WordPress plugin.

jeherve commented 3 years ago

@w33zy That certainly would be an option, although it would be a departure from the way Subscriptions work today; the feature doesn't require any configuration, it works out of the box.

w33zy commented 3 years ago

...it would be a departure from the way Subscriptions work today; the feature doesn't require any configuration, it works out of the box.

@jeherve

You've either missed my point entirely (or you are deliberately dodging it). I specifically referenced using a hook (filter) to solve this issue. How would adding a filter affect the way the subscription module currently works?

Isn't the idea behind WordPress hooks to provide customization to 1% of WP users who are comfortable enough with PHP to write custom code, while allowing the 99% to use WordPress as it was designed?

Are there not any filters in the entirety of Jetpack's codebase?

jeherve commented 3 years ago

Sorry, I should have been clearer. Let me try to rephrase.

Today, the Subscriptions feature doesn't require any kind of configuration; you can toggle the feature on and newly published posts will be sent to your subscribers. Ideally, if one wanted to enable subscription emails for Custom Post Types on their site, the default behaviour would be the same as for Posts. They would enable a toggle for that post type and wouldn't have to do anything else; it would "just work".

For the reasons we've discussed above, that's not an option right now.

Offering the option to enable subscriptions for CPTs via a hook would be an alternative to a full-fledged UI, as you suggested. A simple filter in the plugin wouldn't be enough, as discussed in earlier comments on this issue, but with changes on WordPress.com (where content is processed and where the emails are being sent), it could be possible.

However, it would make that CPT option only available to subset of Jetpack site owners. As you mentioned, this would only be available to people comfortable enough with PHP to write custom code. That's where it would be a departure from the way the Subscriptions works today.

In any case, pushing out emails from Custom Post Types is something we'll consider when we next iterate on the Subscriptions feature. We'll update this issue when we make progress on this.

I hope this clarifies things a bit.

renehesse commented 3 years ago

Is there any news on this already? It's a pity not to be able to use the subscriptions at CPT, even if they correspond to "normal" posts. CPT are generally very poorly supported, until today they are not usable in the wordpress app. CPT are an important tool in wordpress.

github-actions[bot] commented 2 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

brianshim commented 2 years ago

Would love to have the ability for users to subscribe to comments on Pages, thanks.

julsyd commented 1 year ago

Requested in 6039181-zen

github-actions[bot] commented 1 year ago

Support References

This comment is automatically generated. Please do not edit it.