Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Featured Content: settings being overridden by wp-admin changes #787

Open csonnek opened 10 years ago

csonnek commented 10 years ago

User in the support forums reporting that their settings for Featured Content is being changed whenever they make any changes to their settings in Settings -> Reading in the wp-admin dashboard.

Thread: http://wordpress.org/support/topic/saving-reading-settings-resets-featured-content-setting?replies=3

I have not been able to duplicate her exact issue where the tag field is blanked out, but have had similar results.

Steps to reproduce (using Twenty Fourteen):

  1. In Appearance -> Customize, set the featured posts tag to something other than the default "featured" and check the box to hide that tag: http://d.pr/i/JBQ4
  2. Go to Settings -> Reading and change one or more things and save. I've tested changing the blog follow email text, changing the feed from Full to Summary, and hiding the "Related" header for related posts.
  3. Go back to Customize and notice that your settings have been reverted: http://d.pr/i/SYDH

The choice of layout (Grid or Slider) was not changed in my testing.

kraftbj commented 10 years ago

Is this the same as #683?

csonnek commented 10 years ago

@kraftbj it's unclear whether or not those changes in that issue ever made it to master because there were changes, then the changes were reverted - see commits on 9-Jun and 17-Jun here: https://github.com/Automattic/jetpack/commits/master/modules/theme-tools/featured-content.php

stale[bot] commented 6 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

github-actions[bot] commented 3 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.