Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 800 forks source link

Communications error breaks Jetpack's Activity Log rewind feature #8486

Open MichaelArestad opened 6 years ago

MichaelArestad commented 6 years ago

I ran into an issue with one of my sites (no longer in existence) when trying to rewind. All the rewind buttons were greyed out. @thingalon, @singerb, and others looked into it without finding much. I happened to check the wp-admin Jetpack debug page and saw there was a communications error. No one had any suggestions that helped me fix it in a way that would be easy for a user to fix (sorry, but deleting the options table is not easy).

I thought it was maybe a one-off issue with a Pressable test site, but then it appeared again on Rick's site. If it's happening more than once, it could happen to others. This is a big deal since we need our product to reliably be able to back up in crisis.

At the very least, we should be able to fix it. Maybe it's time we built that button to remove/reset the JP options table and turn JP off and on?

jeherve commented 6 years ago

I happened to check the wp-admin Jetpack debug page and saw there was a communications error.

Do you remember what error was listed there? Was this the missing A record error? @rickybanister If you still see the issue, could you check and post the main error here?

Thanks!

MichaelArestad commented 6 years ago

@jeherve The error is labeled:

It looks like your site can not communicate properly with Jetpack.

and contains this:

image

dmsnell commented 6 years ago

Noting here that this is probably an appropriate place to use our designed-but-not-yet-implemented service alerts. We could indicate in a banner or message that we are having trouble talking with the site and thus Rewinding is disabled.

cc: @rcoll

lezama commented 6 years ago

@rcoll @MichaelArestad do you still have a site on that state? could you add me as an Administrator?

MichaelArestad commented 6 years ago

Added.

lezama commented 6 years ago

image

😅

lezama commented 6 years ago

@MichaelArestad everything was working on @rcoll's site, is there a known path to replication?

MichaelArestad commented 6 years ago

@lezama huh. It was busted when I sent you the invite. Did you accidentally fix it?

lezama commented 6 years ago

didn't touch anything :magic:

MichaelArestad commented 6 years ago

Dang. Well. Let's shelve this for now unless someone else runs into it.

happychait commented 6 years ago

I noticed this error on my test Atomic site and another live Atomic site too when I click “Support” link under the Jetpack plugin on Installed Plugins WP Admin page. A user confirmed seeing this error by taking this route too.

Reported in #967687-zen

lezama commented 6 years ago

@enejb I think it is a good idea to somehow show on wp-admin when sync isn't working properly. @MichaelArestad any design suggestions?

enejb commented 6 years ago

We used to have that but when we moved to a react interface it disappeared.

rickybanister commented 6 years ago

I think we can just use a notice on the jetpack dashboard, essential it would look like a just in time message.

rickybanister commented 6 years ago

@MichaelArestad could you mock something simple up for this? cc @keoshi

stale[bot] commented 5 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.