search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Don't include noindex pages in Sitemap #8826

Open danjjohnson opened 6 years ago

danjjohnson commented 6 years ago

931303-zen

User reported that /register, /login and /lostpassword WP pages are marked as noindex but our sitemap is including them, causing errors in the Google Search Console.

Using Theme My Login plugin which is setting any login/register page to noindex: https://github.com/wp-plugins/theme-my-login https://wordpress.org/plugins/theme-my-login/

Can we automatically exclude noindex pages from the generated sitemap?

kraftbj commented 6 years ago

Hmm. The plugin uses the Core noindex function hooked onto wp_head to add the noindex element. I don't think we can tell, from the post object, that it is supposed to be noindex.

We can likely use this function from that plugin https://github.com/wp-plugins/theme-my-login/blob/7dd2391f435b6a3416b72bd66416f142aefc145b/includes/class-theme-my-login.php#L876 and hook onto our _skip_post hooks (e.g. https://github.com/Automattic/jetpack/blob/5.8/modules/sitemaps/sitemap-builder.php/#L993 ).

Could be something we add as a third-party integration if merited.

chaselivingston commented 6 years ago

Also reported in 1148504-zen for Cart and Checkout pages.

stale[bot] commented 6 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

danmaze commented 3 years ago

Also reported in 4246503-zen for cart, checkout, and user account pages.