Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Photon: Not Resizing to the new WooCommerce Thumbnail #9345

Open tmmbecker opened 6 years ago

tmmbecker commented 6 years ago

Woocommerce changed the way product thumbnail images are handled in version 3.3, adding a new image size that is by default 100x100px. Photon doesn't pay attention to this change.

If Photon is deactivated, the product gallery thumbnails show as square:

screen shot on 2018-04-18 at 11_20_42

If Photon is active, the thumbnails show as rectangles the way they used to before Woocomerce changed:

screen shot on 2018-04-18 at 11_21_28

Internal ref: 1005403-zen, 1063044-zen

This is reproducible on any site. Per @jeherve, the problem appears to be linked to how some themes can declare support for wc-product-gallery-slider

Originally reported in 1928-gh-jpop-issues

anaemnesis commented 6 years ago

Original user is requesting an update in 1317075-zen

macmanx2 commented 5 years ago

Original user has requested another update in 1581610-zen

madeincosmos commented 5 years ago

Also reported in 1802679-zen

jeherve commented 1 year ago

Also reported in #30404

github-actions[bot] commented 1 year ago

Support References

This comment is automatically generated. Please do not edit it.

cuemarie commented 1 year ago

Sharing @ash1eygrace 's notes and steps to replicate from #30404 here:

Quick summary

For WooCommerce sites, a problem arises when both thumbnail crop settings and Jetpack's Image CDN are enabled. When the thumbnail crop ratio is set to 1:1 in Customizer → WooCommerce → Product Images, the cropping fails to maintain the desired ratio when Jetpack's Image CDN is active.

Deactivating the Image CDN solves the issue.

Steps to reproduce

  1. Set up an Atomic site on WordPress.com or create a self-hosted WordPress site.
  2. Install and activate WooCommerce.
  3. In Customizer, navigate to WooCommerce → Product Images and set the image crop ratio for thumbnails to 1:1.
  4. Create a product and add portrait-sized images (height greater than width) to the Product Gallery in the product.
  5. Install and activate Jetpack, then enable the Image CDN module at {siteaddress.com}/wp-admin/admin.php?page=jetpack_modules

The image thumbnails on the product pages should maintain a perfect square crop (1:1) based on the settings in Customizer. Instead: The image thumbnail cropping does not retain the 1:1 ratio when Jetpack's Image CDN is enabled. Instead, the images just display as the default image ratio without honoring the crop:

screenshot
cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

Screenshots/Recordings

Markup on 2023-05-03 at 10:18:13

Markup on 2023-05-03 at 10:19:17

📌 ACTIONS

jorpdesigns commented 1 year ago

Reported in 6254100-zd-woothemes