search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 797 forks source link

Feedback Submissions: Store author email as metadata #9531

Open jaswrks opened 6 years ago

jaswrks commented 6 years ago

An upcoming version of WP core will support a personal data exporter/eraser and this commit added support for it. Personal data in Jetpack contact form submissions is identified by looking for Jetpack Feedback posts authored by a specific email address.

While working on that I discovered that in order to identify Feedback submissions associated with a specific email address I'd have to search the entire post_content column for a text fragment containing the author's email address on a line by itself; i.e., the author's email address is not stored anywhere else. This is more expensive that it needs to be.

Ideally, we would begin storing the author's email address in Feedback submissions as metadata. This way a search by email address would be more accurate/efficient.

Perhaps, at some point (maybe as a part of this work) we should consider storing all of the fields collected by contact forms as metadata. I think the current approach is not as extensible as it could be. The current approach being that everything is added to the post_content column.

Reminder: Please re-review D13087-code when this task is completed.

stale[bot] commented 5 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.