search

Automattic / knox

S3 Lib
MIT License
1.74k stars 285 forks source link

Vowels with diacritics in filenames not supported? #215

Closed ejeklint closed 10 years ago

ejeklint commented 10 years ago

Swedish vowels doesn't work well in file names. Uploading "BR Rödräv.txt" works fine, but when trying to delete it from S3 with knox it fails.

domenic commented 10 years ago

Hmm, there have been some recent fixes to handle non-ASCII characters. My guess is those fixes didn't propagate through to the delete code as well. If you want to dig into things by looking at recent commits and seeing if they missed anything, that would probably be helpful; from there you can feel free to submit a pull request! Otherwise I'll try to get around to it sometime after the holidays.

ejeklint commented 10 years ago

I'll return to this later and see what I can come up with.

ejeklint commented 10 years ago

OK, this is not an issue with knox, it's in Dropzone.js - at least that's my gut feeling right now. File names are encoded differently when doing a POST to my /upload route than when DELETE. Sorry about the noise. :)