search

Automattic / knox

S3 Lib
MIT License
1.74k stars 285 forks source link

uncaught errors #239

Closed tj closed 10 years ago

tj commented 10 years ago

Getting multiple errors after the handlers have been removed in a response, which seems a little weird since we're not using agents.. haha, anyway:

UNHANDLED response Error: read ECONNRESET
    at errnoException (net.js:904:11)
    at onread (net.js:558:19)
---------------------------------------------
    at Readable.on (_stream_readable.js:689:33)
    at http.js:1753:12
    at process._tickCallback (node.js:415:13)
---------------------------------------------
    at ClientRequest.onSocket (http.js:1730:11)
    at new ClientRequest (http.js:1432:10)
    at exports.request (https.js:123:10)
    at Client.request (/srv/red-extract/releases/0.3.0/node_modules/knox/lib/client.js:313:42)
    at Client.get (/srv/red-extract/releases/0.3.0/node_modules/knox/lib/client.js:588:15)
    at Client.getFile (/srv/red-extract/releases/0.3.0/node_modules/knox/lib/client.js:607:18)
    at Exporter.start (/srv/red-extract/releases/0.3.0/node_modules/s-s3-export/index.js:52:6)
    at new Exporter (/srv/red-extract/releases/0.3.0/node_modules/s-s3-export/index.js:31:8)
    at Reader.<anonymous> (/srv/red-extract/releases/0.3.0/index.js:125:14)

we get hundreds of those, ignoring them after a callback wouldn't be great but beats exploding the process

domenic commented 10 years ago

Probably only as of the newest release right? I knew that code seemed a bit fragile.

Wish we could write good tests for this sort of thing, grr. Maybe I'll figure out some hacks to inject mock req/res pairs or something.

From: TJ Holowaychukmailto:notifications@github.com Sent: ý2014-ý06-ý18 16:00 To: LearnBoost/knoxmailto:knox@noreply.github.com Subject: [knox] uncaught errors (#239)

Getting multiple errors after the handlers have been removed in a response, which seems a little weird since we're not using agents.. haha, anyway, proof:

UNHANDLED response Error: read ECONNRESET at errnoException (net.js:904:11)

at onread (net.js:558:19)

at Readable.on (_stream_readable.js:689:33)
at http.js:1753:12
at process._tickCallback (node.js:415:13)
at ClientRequest.onSocket (http.js:1730:11)
at new ClientRequest (http.js:1432:10)
at exports.request (https.js:123:10)
at Client.request (/srv/red-extract/releases/0.3.0/node_modules/knox/lib/client.js:313:42)
at Client.get (/srv/red-extract/releases/0.3.0/node_modules/knox/lib/client.js:588:15)
at Client.getFile (/srv/red-extract/releases/0.3.0/node_modules/knox/lib/client.js:607:18)
at Exporter.start (/srv/red-extract/releases/0.3.0/node_modules/s-s3-export/index.js:52:6)
at new Exporter (/srv/red-extract/releases/0.3.0/node_modules/s-s3-export/index.js:31:8)
at Reader.<anonymous> (/srv/red-extract/releases/0.3.0/index.js:125:14)

we get hundreds of those

[https://camo.githubusercontent.com/2418efe6442a5cd8454f402b91b8c01a59b79542/687474703a2f2f77696c6c69616d6265656d2e636f6d2f77702d636f6e74656e742f75706c6f6164732f323031322f30332f5361642d50616e64612e6a7067]https://camo.githubusercontent.com/2418efe6442a5cd8454f402b91b8c01a59b79542/687474703a2f2f77696c6c69616d6265656d2e636f6d2f77702d636f6e74656e742f75706c6f6164732f323031322f30332f5361642d50616e64612e6a7067

— Reply to this email directly or view it on GitHubhttps://github.com/LearnBoost/knox/issues/239.

tj commented 10 years ago

looks like we've got 0.8.10, I'll give 0.9.0 a try

tj commented 10 years ago

woot, seems fixed in 0.9.0, at least for that app