add expect100Continue option

Automattic / knox

S3 Lib

MIT License

1.74k stars 285 forks source link

add expect100Continue option #241

Closed kwangsu61 closed 10 years ago

kwangsu61 commented 10 years ago

add expect100Continue option for Client#put (options not to send "Expect: 100-continue" header)

I use the storage (not S3) that does not support "Expect: 100-continue". I added expect100Continue option for CreateClient(). (default : expect100Continue = true)

domenic commented 10 years ago

I am not even sure why we add that header, given that we don't listen for the continue event. It would be better to just remove it I think.

kwangsu61 commented 10 years ago

Knox library adds "Expect: 100-continue" for http PUT. I just made expect100Continue option not to send it because the storage (that I use, based on openstack swift) does not work normally. In case of S3, I'm not sure that how much helpful it to add "Expect: 100-continue" for http PUT.

domenic commented 10 years ago

Yes, I don't think we should send it for S3 either.

kwangsu61 commented 10 years ago

Yes, please remove "Expect: 100-continue". Thank you for great library!