search

Automattic / knox

S3 Lib
MIT License
1.74k stars 285 forks source link

Use official SDK as low-level implementation, or clarify advantages of not doing so #263

Open boutell opened 9 years ago

boutell commented 9 years ago

I think it makes sense to either use the official AWS SDK as the actual implementation of talking to AWS, or clarify the advantages of avoiding that implementation. It would also be helpful to understand whether the goal is to pursue new features, or just maintain knox for existing apps on the assumption that most users are migrating to the SDK.

I'm suggesting these questions be addressed in the documentation.

marr commented 9 years ago

:+1:

aseemk commented 8 years ago

We've moved over to the official AWS SDK, and we've been pretty happy.

stephenyeargin commented 8 years ago

@TooTallNate Can you or a teammate weigh on this one? Not sure who all is on the Owner/Collaborator roster.

avimar commented 8 years ago

I don't know if it was on purpose, but andrewrk would say it's a great choice to avoid the official SDK. See: https://github.com/andrewrk/node-s3-client/issues/129

adamreisnz commented 7 years ago

@avimar doesn't he advocate the exact opposite?

So if this module is going to survive, it must be changed to remove the dependency on the aws sdk js package and instead make direct HTTP requests, like knox already does.

And:

I made a fundamental mistake when making this library, which was depending on the official AWS SDK package, which is probably the worst piece of shit JavaScript package I've ever depended on.

avimar commented 7 years ago

@adambuczynski Uhm. That's what I meant. I'm not sure why I worded it that way!