search

Automattic / knox

S3 Lib
MIT License
1.74k stars 285 forks source link

fix failing tests in node v0.11.14. #270

Closed bcoe closed 9 years ago

bcoe commented 9 years ago

Object.keys() being called on a null query string was causing tests to fail on node v0.11.14.

To reproduce:

  1. nvm use v0.11.14.
  2. run the auth tests: ./node_modules/.bin/mocha test/auth.test.js.
domenic commented 9 years ago

Dupe of #250, #251, #252, #253, #256, #257.

domenic commented 9 years ago

io.js does not have this problem; you should not be using Node 0.11.

bcoe commented 9 years ago

As a library developer, I take it upon myself to ensure that my application works on as many platforms as possible. Given that it's a small patch to get Knox working almost 100% on Node 0.11 branches, it seems like a good action to take, if only for the benefit of other libraries consuming Knox.

I certainly appreciate your point of view, but from my perspective, it opens more support tickets against projects I have that consume Knox.