Closed philipjohn closed 6 years ago
I'd like to see this repo support PHPCS checks locally - that is, PHPCS/WPCS/VIPCS/PHPCompatibilityWP all required as development dependencies in Composer, and then a .phpcs.xml.dist
config file to handle that all.
Once that's done, then all that's needed in Travis (when running sniff checks), is a composer install
, rather than individual git clones.
Part of what I'd want to see done with the .phpcs.xml.dist
is handled in this PR by @paulschreiber so it may be worth getting that reviewed and merged.
It looks like PHPCS isn't running as expected via Travis on Pull Requests. Rather than failing, the Travis tests are passing, masking the fact that there's even an issue.
We need to:
WordPress-VIP-Go
ruleset from VIP Coding Standards