search

Automattic / liveblog

Liveblogging done right. Using WordPress.
https://wordpress.org/plugins/liveblog/
308 stars 122 forks source link

Fix PHPCS sniffs on PRs #540

Closed philipjohn closed 6 years ago

philipjohn commented 6 years ago

The command "if [[ "$SNIFF" == "1" ]]; then $PHPCS_DIR/scripts/phpcs -p -s -v -n . --standard="WordPress-VIP" --extensions=php; fi" exited with 0.

It looks like PHPCS isn't running as expected via Travis on Pull Requests. Rather than failing, the Travis tests are passing, masking the fact that there's even an issue.

We need to:

GaryJones commented 6 years ago

I'd like to see this repo support PHPCS checks locally - that is, PHPCS/WPCS/VIPCS/PHPCompatibilityWP all required as development dependencies in Composer, and then a .phpcs.xml.dist config file to handle that all.

Once that's done, then all that's needed in Travis (when running sniff checks), is a composer install, rather than individual git clones.

Part of what I'd want to see done with the .phpcs.xml.dist is handled in this PR by @paulschreiber so it may be worth getting that reviewed and merged.