search

Automattic / liveblog

Liveblogging done right. Using WordPress.
https://wordpress.org/plugins/liveblog/
311 stars 122 forks source link

Release v1.9.6 #654

Closed philipjohn closed 2 years ago

GaryJones commented 4 years ago

@okupdatenumber Please open a new issue, with as much detail as possible - what WP version? What Liveblog version? Was it working correctly with a previous version? Have you disabled other plugins and custom code / used a fresh install to show it's not a conflict? Give us the minimum setup needed to be able to reproduce the issue ourselves, so that we can then try and debug and find a solution.

okupdatenumber commented 4 years ago

https://github.com/Automattic/liveblog/issues/656#issue-589942960

philipjohn commented 3 years ago

There have been further merges to master since this PR was opened, so I've rebased and updated the changelog to reflect the other bug fixes that can now be included in v1.9.6

GaryJones commented 3 years ago

Question on whether it has been tested on latest WP, and if so, could that Tested up to readme line be updated?

I also wonder whether we could do something like https://github.com/Parsely/wp-parsely/pull/187 first - GitHub action for auto-deploy to WordPress.org repo when adding a tag, readme.txt consolidated into README.md, screenshots numbering fixed and moved to .wordpress-org directory, changes extracted into CHANGELOG.md etc. All of these would ideally be done anyway, so doing it before this release just simplifies the release process (particularly the deploy to SVN).

Alternatively, if there's a time-pressure, then good to go on these 1.9.6 changes, and the other bits can be picked up before the next release.

philipjohn commented 2 years ago

Auto-deploying would be great, agreed. I'll work on that separately!

philipjohn commented 2 years ago

FYI, auto-deployment in #675

GaryJones commented 2 years ago

At least one of the failing tests hasn't been touched for 5-9 years, so I think this logic was always flawed. The previous Travis configuration only tested up to PHP 7.0, so the issue was only revealed when the repo was switched to GitHub Actions, and up to PHP 7.4 was also tested.