Automattic / liveblog

Liveblogging done right. Using WordPress.
https://wordpress.org/plugins/liveblog/
308 stars 122 forks source link

FIX: Liveblog scheduled cron event auto_archive_check_hook does not get run #676

Closed speedyprem closed 2 years ago

speedyprem commented 3 years ago

There will not have any impact on the application, but It schedules the event for the previous midnight.

This fix will change the schedule to one of the future dates from today midnight to tomorrow.

philipjohn commented 3 years ago

Thanks for this @speedyprem! Can you talk more about the issue you're seeing with this event not firing? I'm not aware of any reports of this issue as yet.

speedyprem commented 3 years ago

Thanks for this @speedyprem! Can you talk more about the issue you're seeing with this event not firing? I'm not aware of any reports of this issue as yet.

@philipjohn It has cropped up in multisite because of the sites are in multiple timezone like UK, USA, and Irish. In this case the event auto_archive_check_hook gets scheduled for the previous midnight, so doesn't get run automatically for US sites.

philipjohn commented 3 years ago

Hmm okay, that's interesting. Are you seeing Liveblogs remain active when they should have been auto-archived, or was it a backup of cron events that made you aware of the problem?

speedyprem commented 3 years ago

Hmm okay, that's interesting. Are you seeing Liveblogs remain active when they should have been auto-archived, or was it a backup of cron events that made you aware of the problem?

Yes, Liveblogs remain active.

philipjohn commented 3 years ago

Are you able to outline your set up for me please? E.g. what sites are in your multisite, what timezone are they on, is Liveblog network active, and any other information that may be relevant? I want to try and replicate the issue to confirm the bug.

speedyprem commented 3 years ago

Are you able to outline your set up for me please? E.g. what sites are in your multisite, what timezone are they on, is Liveblog network active, and any other information that may be relevant? I want to try and replicate the issue to confirm the bug.

what sites are in your multisite We have 6 sites with 2 timezone and all are news sites.

what timezone are they on

  1. UK timezone
  2. US timezone

Yes, Liveblog is network active for all sites.