search

Automattic / media-explorer

With Media Explorer, you can now search for tweets and videos on Twitter and YouTube directly from the Add Media screen in WordPress.
126 stars 31 forks source link

Add spinner to 'insert' button view for AJAX pagination #11

Closed pepegar closed 11 years ago

pepegar commented 11 years ago

The idea being that when you've triggered infinite scroll, your eye will be at the bottom of the page, and that's where another spinner should be.

It needs to be in that View (not sure what the name of it is -- the toolbar?) as opposed to the bottom of the results view so that it's always visible and has a static position.

paulgibbs commented 11 years ago

Keep the top spinner. It's great for when searches are made.

But add a new spinner that appears only when loading with IS, and use the default WP spinner like you said :)

pepegar commented 11 years ago

Ok, thanks Paul.

Solved in 2845bb1533143becf10f6a67e403bdffdeabe9bb. I have left the actual spinner image because this is the only spinner image that comes with WordPress. There is another spinner image in Jetpack, but I haven't used it because the user may have not Jetpack installed.

paulgibbs commented 11 years ago

We pulled this out on dd9db46484ed74786da3eaecbc4f61e26dfe1346 because we decided to move this new spinner onto the bottom-most view (the one with the 'insert' button). How to do this wasn't immediately obvious.