Automattic / musictheme

A theme for bands and musicians that uses an experimental Gutenberg layout.
GNU General Public License v2.0
87 stars 11 forks source link

Infinite scroll doesn't work #27

Closed laurelfulford closed 6 years ago

laurelfulford commented 6 years ago

When using Infinite scroll, the theme doesn't load new posts.

Looks like it might be an ID mismatch in the IS settings -- it set to look for an ID of main to load more posts into, but that doesn't exist in the theme:

https://github.com/Automattic/musictheme/blob/master/inc/jetpack.php#L20

kjellr commented 6 years ago

I committed a few changes:

I'm still seeing some weirdness though. I can't get this to consistently work across my test sites, and WP Admin says it'll show 0 posts on each load... 🙄

screen shot 2018-04-25 at 9 20 23 am

I'll keep digging, but let me know if this rings a bell for anyone else.

allancole commented 6 years ago

Should be fixed in that ^ commit. I think this can be closed but may need a second eye ;-)

kjellr commented 6 years ago

The click variation is working well. I had a question about that here.

I saw you addressed the horizontal scroll via 041f89d19393fe041eb2bb5eea0bd20b6b750d95, but I'm still seeing it:

scroll

allancole commented 6 years ago

Fixed the click variation issue in: 345601d767de1acf5515e461d7531f589fea19d7

Fixed the horizontal scrolling thing here: 4e2058bbbf648bb53add348b8771a0c5844188bc

kjellr commented 6 years ago

LGTM! 🚢