Closed laurelfulford closed 6 years ago
I committed a few changes:
main
was definitely wrong, so I changed that to primary
. I'm still seeing some weirdness though. I can't get this to consistently work across my test sites, and WP Admin says it'll show 0 posts on each load... 🙄
I'll keep digging, but let me know if this rings a bell for anyone else.
Should be fixed in that ^ commit. I think this can be closed but may need a second eye ;-)
The click variation is working well. I had a question about that here.
I saw you addressed the horizontal scroll via 041f89d19393fe041eb2bb5eea0bd20b6b750d95, but I'm still seeing it:
Fixed the click variation issue in: 345601d767de1acf5515e461d7531f589fea19d7
Fixed the horizontal scrolling thing here: 4e2058bbbf648bb53add348b8771a0c5844188bc
LGTM! 🚢
When using Infinite scroll, the theme doesn't load new posts.
Looks like it might be an ID mismatch in the IS settings -- it set to look for an ID of
main
to load more posts into, but that doesn't exist in the theme:https://github.com/Automattic/musictheme/blob/master/inc/jetpack.php#L20