search

Automattic / musictheme

A theme for bands and musicians that uses an experimental Gutenberg layout.
GNU General Public License v2.0
88 stars 11 forks source link

Add customizer color settings #37

Open kjellr opened 6 years ago

kjellr commented 6 years ago

We have options to set the header text color and page background color in the customizer, but neither option works as intended.

screen shot 2018-04-30 at 9 49 18 am

For the initial launch, I think we could remove both options. We have javascript logic we'd need to rework to get the header text color working right. We could rework the wide width variants to get a page background option working, but I'm not sure it's needed for this gutenberg-focused release.

For the broader launch, I think this is definitely something we'd want to sort out.

@allancole — interested in your thoughts here. I bet you have a better idea of the level of effort required.

allancole commented 6 years ago

Yeah, this should be a pretty simple fix. Although making this work properly might cause some conflicts with how the menu dropdown colors are determined.

kjellr commented 6 years ago

As of 0122a91, I'm switching this from a bug to an enhancement. We've removed the color options from the customizer, but we'll plan to bring these back in the future.