Automattic / newspack-blocks

Gutenberg blocks for the Newspack project.
205 stars 43 forks source link

fix: correct font family #1852

Closed laurelfulford closed 1 month ago

laurelfulford commented 1 month ago

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a tiny error I noticed while testing https://github.com/Automattic/newspack-blocks/pull/1847, but that wasn't introduced in it: the WooCommerce errors are not picking up the right font family.

How to test the changes in this Pull Request:

  1. Navigate to Customizer > Typography, and set the Heading font to something noticeably different than the system UI font used by Newspack UI (I used Chalkboard).
  2. Start a modal checkout using the Donate Block or Checkout Button block.
  3. For the credit card number, use a number that will fail like 4000000000000002.
  4. Note the font family used by the error:

CleanShot 2024-08-22 at 17 07 18

  1. Apply this PR and run npm run build.
  2. Repeat steps 2-4 and confirm the error uses the right sans-serif font:

CleanShot 2024-08-22 at 17 04 04

Other information:

laurelfulford commented 1 month ago

Thanks @adekbadek!