fix(ras-acc): add check for if RAS is enabled to allow checkout

laurelfulford commented 1 month ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR makes it possible to use the modal checkout when RAS isn't enabled, to match the current behaviour on trunk.

The main difference between the RAS-based checkout is that the initial checkout screen will require you to fill our the email address with the other billing details, since it won't be pre-populated from the Sign In/Sign Up screen.

See: 1207817176293825-as-1208164200882316

How to test the changes in this Pull Request:

Start on a test site without RAS enabled, or disable it by running wp option delete newspack_reader_activation_enabled.
Set up three blocks: a regular Checkout Button block, one with a variable product, and a Donate block.
On epic/ras-acc in an incognito window, try to run the checkout in any of the blocks; only the initial variation picker will open.
Apply this PR and run npm run build.
In the incognito window, run through each checkout and confirm it works.
Enable RAS (run wp option update newspack_reader_activation_enabled 1 or use the wizard), or re-test this PR on a second test site with RAS enabled.
Smoke test the checkout flows as a new reader and as a logged in reader and confirm that you get the Sign In prompts at the appropriate points, and that the checkout works as usual.

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

laurelfulford commented 1 month ago

Switching this back to draft mode -- looks like it's not working as I'd hoped!

Edited to add: It was a variable name change at the last moment 🤦‍♀️ Working now!

laurelfulford commented 4 weeks ago

Oh yeah, that would be nicer 😄 I'll dig into that tomorrow!

laurelfulford commented 4 weeks ago

Replaced with https://github.com/Automattic/newspack-plugin/pull/3396, and closing -- thanks @chickenn00dle!

Automattic / newspack-blocks