fix: revert check for is product purchaseable

laurelfulford commented 1 month ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR reverts https://github.com/Automattic/newspack-blocks/pull/1916.

That change introduced some unintended consequences, like buttons not appearing once a reader had purchased the membership product they were selling.

This needs to be reworked to focus on the lack of price (the underlying issue), and not a generic "is purchasable" check because that's not quite the same thing -- I'll work on that in the RAS-ACC branch.

How to test the changes in this Pull Request:

Apply the PR and run npm run build.
Confirm you can add checkout button blocks, even for products without prices.
Spot check against the code changes in https://github.com/Automattic/newspack-blocks/pull/1916.

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

laurelfulford commented 1 month ago

Thanks @chickenn00dle! 🙌

matticbot commented 2 weeks ago

:tada: This PR is included in version 4.3.5-alpha.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

matticbot commented 1 week ago

:tada: This PR is included in version 4.3.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Automattic / newspack-blocks