Dont cache blocks for staff - Githubissues

Automattic / newspack-blocks

Gutenberg blocks for the Newspack project.

207 stars 43 forks source link

Dont cache blocks for staff #1929

Closed claudiulodro closed 3 weeks ago

claudiulodro commented 3 weeks ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Note: This is a hotfix

This PR adjusts the block caching logic so that it only applies to readers and does not apply to staff.

How to test the changes in this Pull Request:

You should get cached blocks as a logged out user.
You should get cached blocks as a logged in reader (subscriber role or similar)
You should not get cached blocks as a logged in editor or admin

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

matticbot commented 3 weeks ago

:tada: This PR is included in version 4.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: