feat: add support for Newspack Guest Contributor in HPP blocks

Automattic / newspack-blocks

Gutenberg blocks for the Newspack project.

207 stars 43 forks source link

feat: add support for Newspack Guest Contributor in HPP blocks #1934

Open leogermani opened 3 weeks ago

leogermani commented 3 weeks ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adds support for the Newspack's Guest Contributor role in the Homepage posts and Carousel blocks

How to test the changes in this Pull Request:

Create a user with only the Guest Contributor role and assign a post to it
Add a Home page posts block
Search by that author name and confirm it finds the author and their posts
Do the same for the Carousel block

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

leogermani commented 1 week ago

Looks like requests in the admin are not offloaded to ES.

I'm struggling to test this. @miguelpeixe could you have a look?

leogermani commented 4 days ago

@dkoo To be fair, this PR does not touch the Query for posts. It only touches the query for authors in the Authors filter input...

miguelpeixe commented 4 days ago

Paging @miguelpeixe who worked on the ES integration in case it's obvious to you.

~~That was an issue in the first implementation of the ES, which has been fixed since https://github.com/Automattic/newspack-manager/pull/275. Can you confirm you have the latest manager?~~

I may have misunderstood the issue. It works in the editor but on the front-end. If you have ES enabled for Newspack Blocks that might be a new uncovered incompatibility. We should flag that in Asana for further exploration.

miguelpeixe commented 4 days ago

It only touches the query for authors in the Authors filter input...

The ES incompatibility might be in trunk, to any query filtering CAP authors.

leogermani commented 4 days ago

It only touches the query for authors in the Authors filter input...

The ES incompatibility might be in trunk, to any query filtering CAP authors.

They are not CAP authors. It's just another user role. But they are regular wp users

leogermani commented 3 days ago

I may have misunderstood the issue. It works in the editor but on the front-end.

afaik queries are not offloaded to ES in the admin, only in the front end