Automattic / newspack-blocks

Gutenberg blocks for the Newspack project.
207 stars 43 forks source link

fix(modal-checkout): use post checkout text option to populate thank you page text #1941

Closed chickenn00dle closed 2 weeks ago

chickenn00dle commented 2 weeks ago

All Submissions:

Changes proposed in this Pull Request:

Goes with and should be merged after https://github.com/Automattic/newspack-plugin/pull/3533

This PR uses the new post checkout success text setting added in the main plugin PR linked above.

Screenshot 2024-11-07 at 17 09 04

How to test the changes in this Pull Request:

Be sure to checkout https://github.com/Automattic/newspack-plugin/pull/3533 before testing

  1. As admin, ensure the Prompt logged out readers to sign in or register a new account before checkout setting is DISABLED via Newspack > Engagement > Show Advanced Settings > Checkout Configuration
  2. As a logged out reader, go through checkout using a new email address not associated with an existing user account until you get to the thankyou modal.
  3. Verify whatever text in the post-checkout registration success message setting appears in the thankyou modal
  4. As a logged in reader, go through checkout again until you get to the thankyou modal.
  5. Verify whatever text in the post-checkout success message setting appears in the thankyou modal
  6. As a logged out reader, go through checkout again, this time using an email address associated with an existing user, until you get to the thankyou modal.
  7. Verify whatever text in the post-checkout success message setting appears in the thankyou modal
  8. As admin, enable the toggle from step 1
  9. Go through checkout as a logged out new user, a logged out existing user, and a logged in reader
  10. In all cases confirm the post-checkout success message appears in the thankyou modal

Other information: