Automattic / newspack-blocks

Gutenberg blocks for the Newspack project.
207 stars 43 forks source link

feat(homepage-articles): rename block and reorganise settings #1943

Closed thomasguillot closed 1 week ago

thomasguillot commented 1 week ago

All Submissions:

Changes proposed in this Pull Request:

You can read more about the logic behind this change here: P2-pfaSwu-iT

The main reasons are:

Before:

homepage-posts-settings-before

After:

content-loop-settings-after content-loop-styles

How to test the changes in this Pull Request:

  1. Add a bunch of Homepage post block to a page with various settings
  2. Switch to this branch
  3. Check if the blocks are still displaying the correct information and has kept the correct settings

Other information:

thomasguillot commented 1 week ago

We will need to do a big round of updates to our documentation before this lands.

Absolutely!

Would you like to tackle the other block in a separate PR?

Yes, this was my plan.

github-actions[bot] commented 1 week ago

Hey @, good job getting this PR merged! :tada:

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! :heart:

matticbot commented 1 week ago

:tada: This PR is included in version 4.4.0-alpha.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: