fix: correct spacing of under-Stripe checkmarks - Githubissues

Automattic / newspack-blocks

Gutenberg blocks for the Newspack project.

207 stars 43 forks source link

fix: correct spacing of under-Stripe checkmarks #1953

Closed laurelfulford closed 1 week ago

laurelfulford commented 1 week ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR fixes the spacing of checkboxes that appear under the Stripe payment gateway.

See: 1207817176293825-as-1208730419008818

How to test the changes in this Pull Request:

Start with a site using Stripe Gateway.
Under the RAS settings, enable the option for reader to pay the Stripe fees.
As a reader, run through a One-Time donation purchase.
On the second screen, note the two checkboxes are touching:

CleanShot 2024-11-13 at 11 03 12

Apply this PR and run npm run build.
Confirm the issue is fixed.

CleanShot 2024-11-13 at 11 03 37

Try a checkout with a monthly/yearly donation (which won't have the checkbox about saving information), and try disabling the fees checkbox to make sure things still look okay.

Other information:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

laurelfulford commented 1 week ago

Thanks @dkoo!