Closed leogermani closed 1 week ago
Hey @leogermani, good job getting this PR merged! :tada:
Now, the needs-changelog
label has been added to it.
Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.
If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.
Thank you! :heart:
All Submissions:
Changes proposed in this Pull Request:
When searching for posts from an author that is a WP User (not a guest author), we should also (actually maybe only) search by term slug.
This PR adds a few extra conditions to make sure we find posts by an author when searching by terms.
The specific case we are fixing here is from users that ended up with their Display Name as the term
name
, and thus the search term name using the user_login as input would never find anything. We also need to search by user_nicename and make sure we search in the slug field.How to test the changes in this Pull Request:
post_author
field in the databasetrunk
it won't show up)post_author
field in the DB still points to your adminOther information: