Closed jeryj closed 4 years ago
@laurelfulford do you recall why we added the update date here? https://github.com/Automattic/newspack-blocks/blob/master/src/blocks/homepage-articles/templates/article.php#L126
Testing the standalone plugin I never see the doubled date so I haven't been able to replicate this issue. Would there be any harm in removing it from Homepage Posts and Carousel?
It's part of a microformats spec that's often used in themes:
http://microformats.org/wiki/hentry
The doubled date is probably coming from the carousel not explicitly hiding the updated version of the date -- we had the same issue with the Homepage Posts block, because it was assuming that all themes would be hiding that class (which is a bad assumption!).
I think it's probably safe to remove, since we're not implementing it fully (the posts in these blocks don't have the .hentry
class; I'm not sure we're using all the classes we should). If we opt to add that down the road, we'd want to make sure that was all done correctly -- as is I think it's a partial copy-pasta from the theme :)
:tada: This issue has been resolved in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
If a post has been updated and is included in the Articles Carousel, it will show both the publish date and updated date.
To Reproduce Steps to reproduce the behavior:
Screenshots
Expected behavior I think it should only show the publish date or the updated date.