search

Automattic / newspack-content-converter

Plugin that enables automated conversion of pre-Gutenberg post content, to Gutenberg blocks content.
GNU General Public License v2.0
48 stars 12 forks source link

Fixes overlay visibility in Gutenberg #90

Open iuravic opened 3 years ago

iuravic commented 3 years ago

In Chrome, the actual conversion screen was entirely blue since the new WP 5.8.1 version and the GUI progress wasn't visible, e.g.: image

Workflow:

Updating this one CSS line fixes it, just please check that inherit is the correct value. Thanks! image

Additionally, I'm noticing that Firefox and Safari don't display the GUI well. This is a know problem, and if I'm not mistaken we've ignored it until now, because it worked fine in Chrome:

image

image

iuravic commented 3 years ago

All good!

I've added an extra fix in fe2c585 where I'm hiding the skeleton's sidebar and footer.

Hi @thomasguillot , since we've merged a couple of other PRs which solved the GUI visibility issue in the mean time, just checking whether you still wanted to merge fe2c585 to master?

If the answer is yes, I can remove the 464bee19be38bd31a53c3004dc51b9898313d522 diff (remove my change of overflow-y: auto; to overflow-y: inherit; and we can still use this PR to push fe2c585 to master.

thomasguillot commented 2 years ago

@iuravic yes, I think we still need to merge https://github.com/Automattic/newspack-content-converter/commit/fe2c585a56bd10aef8caa261df16ac59c5ac7f03