Automattic / newspack-ios

Newspack for iOS
https://newspack.pub
GNU General Public License v2.0
8 stars 4 forks source link

Issues/91 new cells #96

Closed aerych closed 4 years ago

aerych commented 4 years ago

Refs #91

This PR is a first pass at cell UI for stories, text notes and photos, and stubbed cells for video and audio notes.

There is a lot of boiler plate in the changes (and project file and xib changes). Some highlights are:

Note: The behavior of the "cloud-upload" icons/buttons is not fully implemented. It will be revisited when syncing is addressed. Also, video and audio cells are stubs and will see some modifications as video and audio features are implemented, so we'll skip the visual review for now. Everything will get a final future design review closer to the v1 wrap up.

To test:

@jleandroperez could I trouble you for a review of this one? I apologize for the size, but about half of the changes are the xib and project file. 😬

Examples:

Screen Shot 2020-08-18 at 11 29 07 AM Screen Shot 2020-08-18 at 11 29 23 AM Screen Shot 2020-08-18 at 11 30 06 AM Screen Shot 2020-08-18 at 11 29 40 AM Screen Shot 2020-08-18 at 11 30 13 AM Screen Shot 2020-08-18 at 11 29 54 AM
aerych commented 4 years ago

iPad + Light Mode, nearly all of the navigation controls are not visible

This is actually due to the authenticator's navbar and bar button styles being a bit too broadly applied and is resolved in https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/371. The change will be reflected in NiOS the next time I update the auth pod version. :)

jleandroperez commented 4 years ago

Ahhh gotcha, thank you sir!!

peril-automattic[bot] commented 4 years ago

You can trigger an installable build for these changes by visiting CircleCI here.

aerych commented 4 years ago

Thank you Jorge!!