search

Automattic / newspack-newsletters

Author email newsletters in WordPress
GNU General Public License v2.0
112 stars 22 forks source link

Layout preview is "cut off" in WordPress 5.9 #681

Open laurelfulford opened 2 years ago

laurelfulford commented 2 years ago

In WordPress 5.9 RC 2, the layout preview for the newsletter is slightly cut off on the right and left -- you can see it on the paragraph block in the screenshot below, as well as the missing right border on the post inserter block:

image

The newsletter itself seems to display fine.

laurelfulford commented 2 years ago

@miguelpeixe I think you might be the best person to look at this since you'll be testing newsletters overall for 5.9 but please let me know if I should reassign -- thanks!

laurelfulford commented 2 years ago

This is also happening in the Layout preview in the sidebar when you're editing a single newsletter, though it seems likely it's the same cause.

miguelpeixe commented 2 years ago

Thanks, @laurelfulford!

I was able to reproduce the cut-off on Firefox but not on Chrome. The preview is also displaying a scrollbar in some layouts, from what appears to be a height miscalculation of the editor canvas wrapper, which is now iframed.

image

I also was only able to reproduce the fonts issue on Firefox.

I believe all of these issues are related to the new iframed editor canvas. Still investigating 🔍

laurelfulford commented 2 years ago

Thanks for digging into this, @miguelpeixe 🙌 and excellent catch re: Firefox! I didn't consider that this kind of thing would be browser-specific, but that's also the browser I was using when I ran into it.

I'll have to double-check a couple of the other issues I've noticed to see if they're also browser-specific -- that at least offers a "work around", worst-case!