search

Automattic / newspack-plugin

An advanced open-source publishing and revenue-generating platform for news organizations.
https://newspack.com
GNU General Public License v2.0
333 stars 49 forks source link

Donations: Required plugins are not required for NRH #1392

Closed gamebits closed 2 years ago

gamebits commented 2 years ago

If certain WooCommerce plugins are not activated, the /wp-admin/admin.php?page=newspack-reader-revenue-wizard#/donations page will display this error message:

The required plugins are not installed and activated. Install and/or activate them to access this feature.

This error can be displayed regardless of what reader revenue platform is selected. It should be displayed only if newspack_reader_revenue_platform is Newspack, as the required plugins are not necessary for use with NRH.

Perhaps the following code can be placed in a is_platform_wc check:

https://github.com/Automattic/newspack-plugin/blob/a03a45eaa0870e99a0fb63ee0b3ef2004e570552/includes/class-donations.php#L93-L110

adekbadek commented 2 years ago

@gamebits can you confirm if this is still reproducible? Here's what I see with WooCommerce deactivated & platform set to NRH (no error message):

image
matticbot commented 2 years ago

:tada: This issue has been resolved in version 1.72.0-hotfix.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 2 years ago

:tada: This issue has been resolved in version 1.76.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 2 years ago

:tada: This issue has been resolved in version 1.77.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 2 years ago

:tada: This issue has been resolved in version 1.77.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: