feat: add spinner to registration block submit button

chickenn00dle commented 1 month ago

All Submissions:

[ ] Have you followed the Newspack Contributing guideline?
[ ] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207385073694408/1206756862605997/f

The registration block can take a few seconds to complete and the current loading state is not entirely clear for all publishers. This PR adds a loading spinner to the registration form submit button when clicked to make it more clear the form is loading:

https://github.com/Automattic/newspack-plugin/assets/17905991/17048f71-7a3a-456b-be46-dc4ac3adecd5

How to test the changes in this Pull Request:

On a test site, set up a registration wall content gate: https://help.newspack.com/engagement/reader-activation-system/content-gating/#getting-started
Activate the memberships plugin and create a membership plan for all new registrations, restricting all posts to members of this plan
Visit any post on your site as a logged out user and scroll until the registration wall triggers
Enter a valid email address and verify a loading spinner appears within the submit button as shown above

Other information:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

matticbot commented 3 weeks ago

:tada: This PR is included in version 4.4.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 2 weeks ago

:tada: This PR is included in version 4.4.0 :tada: