Closed dkoo closed 2 months ago
All linting, testing, and Typescript check scripts should now be working. This should be ready for production pending QA.
@miguelpeixe I'd say the conflict between formatting and TS rules is non-blocking for now, as I don't think we should reformat our JS at this point because the newer rules in @wordpress/scripts
would result in a huge number of changes in our JS across all repos. If we decide to change our JS formatting to match, we should do so in future PRs and separately from these other changes, and then we can resolve the conflict with our TS rules.
:tada: This PR is included in version 5.0.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
All Submissions:
Changes proposed in this Pull Request:
Refactoring required for changes in https://github.com/Automattic/newspack-scripts/pull/209. Note that this PR will not pass CI tests and should NOT be merged until https://github.com/Automattic/newspack-scripts/pull/209 is released as an NPM package, so this repo can install it as a dependency.
Note: this PR also renames the
assets
folder tosrc
to bring this repo in line with all other Newspack repos' directory structure.How to test the changes in this Pull Request:
Follow instructions in https://github.com/Automattic/newspack-scripts/pull/209.
Other information: