Automattic / newspack-plugin

An advanced open-source publishing and revenue-generating platform for news organizations.
https://newspack.com
GNU General Public License v2.0
324 stars 48 forks source link

feat(everlit): added Everlit to plugins + refactor plugins in connections wizard #3188

Closed jaredrethman closed 3 weeks ago

jaredrethman commented 4 weeks ago

All Submissions:

Changes proposed in this Pull Request:

Everlit plugin management. Due to the nature of the UX implementation of this feature it was necessary to do a rewrite of some of the logic within the <Plugins /> component used within Connections Wizard, namely:

How to test the changes in this Pull Request:

  1. Checkout this branch and build assets i.e. git checkout origin/feat/wizard-everlit-plugin && npm run build
  2. Navigate to /wp-admin/admin.php?page=newspack-connections-wizard
  3. Observer the new ActionCard for Everlit is present.

Screenshot 2024-06-19 at 09 47 32

  1. Click "Install Everlit", once request has completed observe you see the following:

Screenshot 2024-06-19 at 09 48 53

  1. Click "Activate Everlit". Observe:
    • Once request has completed, page will reload (Necessary for Everlit Plugin settings to show once activated)
    • "Everlit" admin menu item exists after reload.
    • The Everlit plugin action card should resemble the below - prompting further setup.

Screenshot 2024-06-19 at 09 55 33

  1. Right click "Complete Setup" and open in a new tab, this will open a tab with Everlit initial setup. Add your details and click "Submit".

Screenshot 2024-06-19 at 09 58 23

  1. Navigate back to Connections tab and refresh page. Observe that further setup is still necessary.

Screenshot 2024-06-19 at 09 55 33

  1. Navigate back to Everlit settings tab and refresh page. Observe that different configuration is now available e.g. "Everlit Token". Add a "Everlit Token" (for testing purposes this can be anything) and click "Save Changes"
  2. Navigate back to Connections tab and refresh. You should now see a successfully configured Everlit plugin.

Screenshot 2024-06-19 at 10 10 48

Other information:

kmwilkerson commented 4 weeks ago

Nice! We can remove the Install step (as it'll be installed by default) and just start right with the activation step

jaredrethman commented 4 weeks ago

Nice! We can remove the Install step (as it'll be installed by default) and just start right with the activation step

@kmwilkerson I can absolutely remove it. Here's some motivations for keeping it:

Let me know your thoughts on the above.

kmwilkerson commented 4 weeks ago

I gotcha -- in that case, keeping it makes total sense @jaredrethman

matticbot commented 3 weeks ago

:tada: This PR is included in version 4.4.0-alpha.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 2 weeks ago

:tada: This PR is included in version 4.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: