feat: update reader registration block to use newspack-ui

thomasguillot commented 3 months ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

The main goal of this PR is to update the Reader Registration block to use Newspack UI, aligning it with the rest of the RAS-ACC flow.

I've removed the styles (Stacked / Columns) as they're no longer relevant, and simplified the "Sign in" field to just a link/button (removing the need for "Already have an account?"), to further align with RAS-ACC.

On the Newspack UI end, I've made a few changes: I've replaced Inter with a new version and added Italic. I've enqueued the script into the editor to make sure the styles are available there.

How to test the changes in this Pull Request:

Add a Reader Registration block to a page.
Switch to this branch and make sure the block still looks fine.
Play with the different settings, etc...

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

thomasguillot commented 2 months ago

@adekbadek both issues should be fixed now.

With the Editor styles, I pushed some minor changes but it looked ok to me

Editor	Front-end

laurelfulford commented 1 month ago

@adekbadek Thanks for keeping this one moving! It was on my list to follow up on it but I didn't get to it. Let me know if it'd help at all to have a second set of eyes reviewing since you're also making commits 🙂

laurelfulford commented 1 month ago

Hey @adekbadek! I just wanted to follow up on this one again to see if there's anything still blocking it from a thumbs up? I'm happy to help with merge conflicts/a second set of eyes/making outstanding fixes, whatever! I think it'd be a nice refresh with the rest of the RAS-ACC changes -- thanks! 🙂

adekbadek commented 4 weeks ago

@laurelfulford – sorry it took so long! 🙈 I've added some tweaks and approved the changes. Since I've contributed code, do you want to give it another review?

laurelfulford commented 2 weeks ago

Hey @adekbadek! Sorry for the late follow up, this completely fell off my radar. Is there anything I can do to help with the changes requested for this one? Happy to help make changes, or answer questions -- just let me know, thanks!

Automattic / newspack-plugin