fix: display transaction fee as an amount instead of a percentage

dkoo commented 3 weeks ago

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Displays the transaction fee as an amount instead of a percentage in the Donate modal checkout flow.

Check out this branch
While using the Newspack Reader Revenue platform, in Newspack > Reader Revenue > Stripe Settings, enable the "Allow donors to cover transaction fees" option but leave the custom message field blank.
As a reader, start a donation transaction and proceed to the payment part of the modal.
Confirm that the default message shows the fee in an absolute currency amount instead of as a percentage:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1207669785215348

dkoo commented 2 weeks ago

Note: this reverts changes from https://github.com/Automattic/newspack-plugin/pull/2746

Yes, but also simplifies the display further by not showing the percentage at all, which is hopefully more user-friendly. Thanks for the review!

matticbot commented 1 week ago

:tada: This PR is included in version 4.5.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 1 week ago

:tada: This PR is included in version 4.5.0-hotfix-add-attributes-loader-effect-hook-deps.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 1 week ago

:tada: This PR is included in version 4.6.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 3 days ago

:tada: This PR is included in version 4.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Automattic / newspack-plugin