Automattic / newspack-plugin

An advanced open-source publishing and revenue-generating platform for news organizations.
https://newspack.com
GNU General Public License v2.0
324 stars 48 forks source link

feat: remove 'Patterns' link from Appearance menu #3221

Closed laurelfulford closed 1 week ago

laurelfulford commented 2 weeks ago

All Submissions:

Changes proposed in this Pull Request:

WordPress 6.6 updates the Core link under WP Admin > Appearance > Patterns to point to the Site Editor.

The Newspack Plugin already includes a link to Patterns and Pattern Categories under Posts, so the link from Core was already redundant. Now it has the possibility of being confusing -- we'll need to get publishers onboarded with the Site Editor when they're moved to block themes, but in the meantime it's unlikely they're using this link, and pushing them into the Site Editor at this point could be confusing.

Note: When a block theme is active, the Patterns link doesn't exist -- there's a Patterns section under Appearance > Editor instead. So adding this change to the Newspack Plugin won't affect the block theme, and keeps the code with the code adding the Patterns under the Posts menu.

How to test the changes in this Pull Request:

  1. From the WordPress Dashboard, note that there's a Patterns link under the Appearance menu.
  2. Apply this PR.
  3. Confirm the Patterns link there is now gone.

Other information:

laurelfulford commented 1 week ago

I'm going to rework this as a hotfix, too, so it gets released ahead of WP 6.6 next week.