Automattic / newspack-popups

Popup notifications.
GNU General Public License v2.0
70 stars 17 forks source link

fix(preview): handle additional_classes #1278

Closed adekbadek closed 7 months ago

adekbadek commented 7 months ago

All Submissions:

Changes proposed in this Pull Request:

Fixes a bug where additional CSS classes were not applied in editor previews.

See 1200550061930446-as-1206541498328358

How to test the changes in this Pull Request:

  1. On trunk, edit a prompt and set some CSS classes in "Advanced Settings" sidebar panel
  2. Trigger a preview, observe the classes are not applied
  3. Switch to this branch, try again, observe the classes are applied to the newspack-popup-container element

Other information:

matticbot commented 7 months ago

:tada: This PR is included in version 2.31.0-alpha.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 7 months ago

:tada: This PR is included in version 2.31.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: