[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Changes proposed in this Pull Request:
When the "Disable prompts on this post or page" setting is turned on for a post or page, the shortcode render method for prompts doesn't pay attention to this filter, which means that any prompts rendered via the shortcode (including Custom Placements and Manual placement prompts) will continue to render. This PR fixes this.
How to test the changes in this Pull Request:
Publish two prompts: one with a custom placement, and the other set to "Manual Only" in the "Everyone" segment.
On a post or page, add a Custom Placement and Single Prompt block, and select the prompts you created in step 1. Enable the "Disable prompts on this post or page" option in the sidebar and publish.
On release, visit the post as a reader and observe that both prompts are rendered despite the option.
Check out this branch and refresh, and confirm that neither prompt is rendered.
Uncheck the "Disable prompts on this post or page" option and save. Refresh the post and confirm that both prompts reappear.
Other information:
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?
To see the specific tasks where the Asana app for GitHub is being used, see below:
All Submissions:
Changes proposed in this Pull Request:
When the "Disable prompts on this post or page" setting is turned on for a post or page, the shortcode render method for prompts doesn't pay attention to this filter, which means that any prompts rendered via the shortcode (including Custom Placements and Manual placement prompts) will continue to render. This PR fixes this.
How to test the changes in this Pull Request:
release
, visit the post as a reader and observe that both prompts are rendered despite the option.Other information: