search

Automattic / newspack-popups

Popup notifications.
GNU General Public License v2.0
70 stars 17 forks source link

Inline placement removed on posts with WooCommerce Memberships restricted content enabled #654

Open akmyta opened 3 years ago

akmyta commented 3 years ago

When WooCommerce Memberships is enabled and post content is restricted, prompts to do not display for logged in members.

Reviewing inspect as a logged-in member, Google Console shows that the prompt is completely removed from posts when content restriction is enabled.

Steps to reproduce:

  1. Create a WooCommerce Membership
  2. Navigate to a post and assign membership and enable content restriction.
  3. View post in incognito, follow sign in prompts to log in as a member
  4. Navigate back to the original post (no prompt is visible)
  5. Navigate to a post where the content restriction is not enabled, prompt will be visible.
tmmbecker commented 3 years ago

Noting that Diaspora reported this. So we should follow up with them once it's fixed.

claudiulodro commented 2 years ago

Worth noting, this is currently a "feature" not a "bug" :) https://github.com/Automattic/newspack-popups/blob/3a199287a36359493b311258ca1f47236f550e59/includes/class-newspack-popups-inserter.php#L352-L353

aschweigert commented 2 years ago

Per @claudiulodro's point, if someone is already a member...what prompts are they (or would they) be shown? Having a little more information on what they're trying to do here would be helpful. I can see a situation where they'd want certain prompt types (event promotion, recirc, etc) to still show for logged in members, so maybe we could add some way to adjust the behavior here based on login/user status