search

Automattic / newspack-theme

A theme for Newspack.
https://newspack.com
GNU General Public License v2.0
300 stars 66 forks source link

WooCommerce: Simplified checkout sometimes hides important information #1124

Open laurelfulford opened 3 years ago

laurelfulford commented 3 years ago

Right now, the simplified checkout strips out standard information to display a simple view for checkout.

Right now, this is stripping out information about coupons, and also causing the total displayed above the billing information to not include discounts added by coupons -- this is very misleading.

claudiulodro commented 3 years ago

I believe this is the relevant part that isn't in our templates: https://github.com/woocommerce/woocommerce/blob/master/templates/checkout/review-order.php#L55-L98

I'm not exactly sure why all of that isn't getting rendered when we fire the woocommerce_checkout_order_review action, though.

philipjohn commented 3 years ago

Related: 3428427-zen

adekbadek commented 2 years ago

@laurelfulford – how does simplified checkout w/ WooCommerce work? How to reproduce the issue?

laurelfulford commented 2 years ago

@adekbadek It's a really old option that was baked into the theme, kind of a first pass at hiding some unneeded elements from the WooCommerce checkout.

The theme option is labelled 'Order Details' - there's a bit more information and screenshots here, but it's basically the ability to hide that order details table in the WooCommerce checkout.

It can be turned on under Customizer > WooCommerce > Order Details:

image

'Hide' and 'Hide, with ability to toggle open' are the two 'simplified' options.

laurelfulford commented 2 years ago

Forgot the actual steps to reproduce part 🤦‍♀️

(Note: I don't think a donation is a real use case for a discount -- it'd be more likely to use with Memberships -- but you just need to run anything through the checkout with a coupon to reproduce, and donations are already set up on most test sites, so this is probably quickest!).

  1. Start on a test site with Donations set up to use Newspack (WooCommerce).
  2. Navigate to Customizer > WooCommerce > Order Details, and switch the Order Details Visibility to Hide or Hide, with ability to toggle open.
  3. Navigate to Dashboard > WooCommerce > Coupons, and create a coupon:

image

  1. Run a donation through the checkout; when you hit the Checkout page, you should see your simplified order summary at the top, and a prompt to enter a coupon:

image

  1. Enter your coupon code and apply; my coupon code should have applied a 20% discount. Note that the order summary at the top does not update to reflect the new amount. (If you have the details set to toggle open, the amount will update in the table, but not in the summary at the top).

image

  1. Navigate back to Customizer > WooCommerce > Order Details, and switch the Order Details Visibility to Show.
  2. Repeat steps 4 and 5; note that the full order summary actually updates with the amount discounted, under 'Total':

image

(Though the recurring total does not 😕 I need to dig into that a bit more to see if that's expected).