Automattic / newspack-theme

A theme for Newspack.
https://newspack.com
GNU General Public License v2.0
305 stars 66 forks source link

fix: make single post subtitle styles more specific #2271

Closed laurelfulford closed 7 months ago

laurelfulford commented 7 months ago

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a small issue where, if you had a Homepage Post block on a single post with the subtitle displaying, it would have a lot of extra space underneath it. This was because the subtitle styles in the theme aren't specific enough.

See 1200024937525366-as-1206994171860195

How to test the changes in this Pull Request:

  1. Add a Homepage Posts block to a widget area on a single post, and enable the subtitles.
  2. View on the front-end; note the extra space under the subtitle:

image

  1. Apply this PR and run npm run build.
  2. Refresh your post; confirm that the subtitle spacing looks okay in the homepage post block.

image

  1. If your single post doesn't have one already, add a subtitle to it and confirm it looks okay (applies spacing underneath the subtitle).

Other information:

laurelfulford commented 7 months ago

Thanks @chickenn00dle! 🙌

matticbot commented 7 months ago

:tada: This PR is included in version 1.87.2-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 6 months ago

:tada: This PR is included in version 1.87.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: