fix: handle attachement fetch failure

adekbadek commented 5 months ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

As seen on a live site, wp_get_attachment_metadata may return false. If it's not handled, a PHP Warning will be logged. This PR adds handling of a false return value from wp_get_attachment_metadata, and refactors code for readability.

How to test the changes in this Pull Request:

Set a featured image on a post or page, observe it behaves as expected.

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

matticbot commented 5 months ago

:tada: This PR is included in version 1.89.0-epic-ras-acc.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 5 months ago

:tada: This PR is included in version 1.89.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 5 months ago

:tada: This PR is included in version 1.89.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Automattic / newspack-theme