fix: dont update option on every request

claudiulodro commented 5 months ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Fixes an issue I noticed while debugging something. The template check never succeeds, so the template cache is cleared on every page load and the template version option is updated on every page load. This is because the option value is the string "1" but the check does a strict compare with integer 1.

I have this as a hotfix because removing this helps performance and it's a tiny change.

How to test the changes in this Pull Request:

Install Query Monitor. Go to any page. In the DB section filter on UPDATE and see the option is updated on every page load.

Apply this patch. Refresh the page. See the option is not updated on every page load any more.

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

matticbot commented 5 months ago

:tada: This PR is included in version 1.88.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 5 months ago

:tada: This PR is included in version 1.89.0-epic-ras-acc.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Automattic / newspack-theme