Automattic / newspack-theme

A theme for Newspack.
https://newspack.com
GNU General Public License v2.0
305 stars 66 forks source link

feat: add specific css for subscribe pattern 5 and 6 #2305

Closed thomasguillot closed 5 months ago

thomasguillot commented 5 months ago

All Submissions:

Changes proposed in this Pull Request:

If you apply https://github.com/Automattic/newspack-blocks/pull/1745 you'll notice that if you use Pattern 5, there isn't a gap between the intro and the form or, if you insert Pattern 6, there's a gap between the image and the card. This PR fixes both issues.

How to test the changes in this Pull Request:

  1. Checkout https://github.com/Automattic/newspack-blocks/pull/1745
  2. Insert Pattern 5 and Pattern 6 to a page
  3. Notice the issues
  4. Switch to this branch
  5. Refresh page. Issues should be gone.

Other information:

matticbot commented 5 months ago

:tada: This PR is included in version 1.89.0-epic-ras-acc.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 5 months ago

:tada: This PR is included in version 1.89.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 5 months ago

:tada: This PR is included in version 1.89.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: