fix: correct title, subtitle order in the editor in WP 6.6 - Githubissues

Automattic / newspack-theme

A theme for Newspack.

https://newspack.com

GNU General Public License v2.0

305 stars 66 forks source link

fix: correct title, subtitle order in the editor in WP 6.6 #2337

Closed laurelfulford closed 4 months ago

laurelfulford commented 4 months ago

All Submissions:

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR updates where the article subtitle preview is inserted in the editor, to correct an order issue that happens with WP 6.6.

It also removes some unused code:

A legacy selector needed for 5.9
Some styles related to the code view of the editor. The Subtitle doesn't seem to insert there in WP 6.5, and I think it's fine; we haven't heard anything about, and it's not editable there, anyway.

See 1207594452716169-as-1207669473649561

How to test the changes in this Pull Request:

Start on a test site running the latest WP 6.6 RC.
Create a post, and add a subtitle in the sidebar; note the editor order:

Apply this PR and run npm run build.
Confirm the editor order now looks better.

Retest this PR on a site running WP 6.5.x, and confirm that it doesn't cause issues (if you're using the WordPress Beta plugin, you can also just roll back your original test site).

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

laurelfulford commented 4 months ago

Redoing this one as a hotfix!