fix: correct subtitle order for WP 6.6

laurelfulford commented 4 months ago

[x] Have you followed the Newspack Contributing guideline?
[x] Does your code follow the WordPress' coding standards and VIP Go coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

This PR updates where the article subtitle preview is inserted in the editor, to correct an order issue that happens with WP 6.6.

It also removes some unused code:

A legacy selector needed for 5.9
Some styles related to the code view of the editor. The Subtitle doesn't seem to insert there in WP 6.5, and I think it's fine; we haven't heard anything about, and it's not editable there, anyway.

See 1207594452716169-as-1207669473649561

Retest this PR on a site running WP 6.5.x, and confirm that it doesn't cause issues (if you're using the WordPress Beta plugin, you can also just roll back your original test site).

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

matticbot commented 4 months ago

:tada: This PR is included in version 1.90.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 4 months ago

:tada: This PR is included in version 1.91.0-alpha.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 4 months ago

:tada: This PR is included in version 1.91.0-epic-ras-acc.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Automattic / newspack-theme