Automattic / newspack-theme

A theme for Newspack.
https://newspack.com
GNU General Public License v2.0
305 stars 66 forks source link

Minify styles #2387

Closed adekbadek closed 4 weeks ago

adekbadek commented 1 month ago

All Submissions:

Changes proposed in this Pull Request:

Adds CSS minification to the created stylesheets.

Also fixes a warning triggered by Sass about rule nesting. Nested rules should be placed after other rules.

How to test the changes in this Pull Request:

  1. Run npm run build and observe the <theme-slug>/style.css files are minified
  2. Smoke-check the front-end to see if it looks as expected

Other information:

adekbadek commented 1 month ago

@dkoo – I've tried upgrading to compile, but ran into errors. I've decided that since it works as it is, it's not worth investing more time into.

dkoo commented 1 month ago

Ok, we can re-cross that bridge when sass introduces a new major version.

matticbot commented 4 days ago

:tada: This PR is included in version 2.1.1-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 4 days ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: