Closed dkoo closed 4 days ago
Hey @dkoo, good job getting this PR merged! :tada:
Now, the needs-changelog
label has been added to it.
Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.
If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.
Thank you! :heart:
:tada: This PR is included in version 2.1.1-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 2.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
All Submissions:
Changes proposed in this Pull Request:
2387 introduced minification for built style.css files, but it didn't make the theme description comment blocks important with a
/*!
prefix for child themes. Without the theme descriptions, release CI jobs fail.This PR adds the important prefixes to all theme description SCSS, and also updates some outdated description args such as supported WP versions, and removing the AMP tag.
How to test the changes in this Pull Request:
npm run build
newspack-*/style.css
built file, confirm that the theme description block appears at the top of the file. It should look like this:Other information: